docs: Recommend pull_diags.nvim instead of manual config for neovim #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinbekal
added
documentation
nithinbekal
commented
Apr 16, 2024
| @@ -61,102 +61,10 @@ mason_lspconfig.setup_handlers { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Neovim Limitations | |||
| ### Limitations | |||
|
|
|||
| Ruby LSP only supports pull diagnostics, and neovim versions prior to v0.10.0-dev-695+g58f948614 only support [publishDiagnostics](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics). | |||
There was a problem hiding this comment.
Discussed with @vinistock and decided that recommending a plugin for something temporary might be overkill.
This line and the comment in the snippet below already makes it clear that v0.10 is still in dev, so I'll close this PR, and update the snippet in the other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the ruby LSP name for neovim here, I noticed that there's a reference to
ruby_lsin a large snippet for enabling pull diagnostics. This has been extracted to a pull_diags.nvim plugin, so I recommended that to make it more approachable. (cc @catlee)I've extracted that commit from the PR, so that it can be discussed separately.