Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rename ruby_ls to ruby_lsp in neovim setup #1936

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

nithinbekal
Copy link
Contributor

@nithinbekal nithinbekal commented Apr 15, 2024

Follow up to this discussion about renaming ruby_ls to ruby_lsp in nvim-lspconfig.

The PR on nvim-lspconfig has shipped: neovim/nvim-lspconfig#3105

Waiting on mason-lspconfig PR to ship: williamboman/mason-lspconfig.nvim#395

Note: While I was renaming the LSP here, I also noticed that there's a reference to ruby_ls in a large snippet for enabling pull diagnostics. This has been extracted to a pull_diags.nvim plugin, so I recommended that to make it more approachable. (Decided against this - context).

@andyw8
Copy link
Contributor

andyw8 commented Apr 15, 2024

This has been extracted to a pull_diags.nvim plugin, so I recommended that to make it more approachable.

Oh that's great, thanks @catlee!

@nithinbekal
Copy link
Contributor Author

@andyw8 I've marked this as draft because we're waiting on the mason-lspconfig fix to ship, so I've moved the pull diagnostics commit to a separate PR here: #1937

@nithinbekal nithinbekal added documentation Improvements or additions to documentation other Changes that aren't bugfixes, enhancements or breaking changes labels Apr 15, 2024
@nithinbekal nithinbekal force-pushed the rename-neovim-lsp branch 2 times, most recently from b6956e0 to 846f168 Compare April 16, 2024 21:35
@nithinbekal nithinbekal changed the title neovim docs: Rename ruby_ls to ruby_lsp docs: Rename ruby_ls to ruby_lsp in neovim setup Apr 16, 2024
@nithinbekal
Copy link
Contributor Author

The mason-lspconfig changes have shipped here: williamboman/mason-lspconfig.nvim#395

This should be good to merge.

@nithinbekal nithinbekal marked this pull request as ready for review April 22, 2024 17:16
@nithinbekal nithinbekal requested a review from a team as a code owner April 22, 2024 17:16
@nithinbekal nithinbekal requested review from st0012 and vinistock April 22, 2024 17:16
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vinistock vinistock merged commit 35186c4 into main Apr 22, 2024
42 checks passed
@vinistock vinistock deleted the rename-neovim-lsp branch April 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation other Changes that aren't bugfixes, enhancements or breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants