Allow configuring linters separate from formatter #1925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1924
Since addons will now be able to register more linters, we need to account for the fact that users may want to lint with multiple tools that are different from their formatter. I suggest we allow configuring an array of linter identifiers, so that we'll gather diagnostics from all of those.
Note: when it comes to auto-formatting, I do not believe we should use all linters for it. I think it's best to follow the example of the TypeScript and Rust community, where linting errors are fixable via code actions, but not through formatting. Users can then configure to have code actions fixed on save with
Implementation
I split by commit.
Automated Tests
Adjusted our tests.