Apply PR suggestion

Shopify · Apr 22, 2024 · 019c876 · 019c876
1 parent ce0a80f
commit 019c876
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/ruby_lsp/global_state.rb b/lib/ruby_lsp/global_state.rb
@@ -62,7 +62,7 @@ def apply_options(options)
       @formatter = detect_formatter if @formatter == "auto"
 
       specified_linters = options.dig(:initializationOptions, :linters)
-      @linters = specified_linters ? specified_linters : detect_linters
+      @linters = specified_linters || detect_linters
 
       encodings = options.dig(:capabilities, :general, :positionEncodings)
       @encoding = if !encodings || encodings.empty?

diff --git a/test/global_state_test.rb b/test/global_state_test.rb
@@ -122,6 +122,16 @@ def test_linter_auto_detection
       assert_equal(["rubocop"], state.instance_variable_get(:@linters))
     end
 
+    def test_specifying_empty_linters
+      stub_dependencies("rubocop" => "1.2.3")
+      state = GlobalState.new
+      state.apply_options({
+        initializationOptions: { linters: [] },
+      })
+
+      assert_empty(state.instance_variable_get(:@linters))
+    end
+
     private
 
     def stub_dependencies(dependencies)