Fix CI #228
Merged
Fix CI #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Gemfile.lock for Ruby head
After Shopify/ruby-lsp#1280, the hover request will now contain information about the class's information too. This previously was not the case because this project has Sorbet in the depdenencies.
vinistock
approved these changes
Jan 12, 2024
st0012
approved these changes
Jan 12, 2024
flavorjones
reviewed
Jan 12, 2024
Comment on lines
+39
to
42
| skip if ENV["BUNDLE_GEMFILE"]&.end_with?("gemfiles/Gemfile-rails-main") | ||
|
|
||
| previous_bundle_gemfile = ENV["BUNDLE_GEMFILE"] | ||
| project_root = Pathname.new(previous_bundle_gemfile).dirname |
There was a problem hiding this comment.
I think I would have preferred to set project_root independently of the BUNDLE_GEMFILE:
project_root = File.expand_path("../..", __dir__)since if any more gemfiles are added to the gemfiles/ subdirectory, this test will start failing again. 🤷
There was a problem hiding this comment.
Ah yes, let's do that: #229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a closing quote in #226.
Also added Stan's fixes from #227