Test against ruby-lsp 0.13.3 #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Shopify/ruby-lsp#1280, the hover request will now contain information about the class's information too. This previously was not the case because this project has Sorbet in the depdenencies.
Merged
|
Done in #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that due to Shopify/ruby-lsp#1280, a test case here needs to be updated to pass with ruby-lsp
0.13.3.The test didn't consider the constant's hover content because it wasn't displayed due to Sorbet being in the bundle. However, after the PR it's now displayed because the test isn't
typed: true.I decided not to fix it by adding
typed: truebecause I think the tests here should reflect usages without Sorbet as it's what majority of the users would see.