Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosts table: Name locator fix (again) #1603

Merged
merged 1 commit into from
Nov 20, 2024
Merged

hosts table: Name locator fix (again) #1603

merged 1 commit into from
Nov 20, 2024

Conversation

pnovotny
Copy link
Contributor

Problem Statement

Re-introducing this fix after being reverted.
This commit unintentionally broke navigation to host details page,
which was caused by another issue in the Sat hosts table
and fixed in #1465

Description:

The HostsView Name table column XPath was missing leading '.' character,
which caused that all host rows that were returned, had the same Name value,
equal to the first table row host Name.

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.15.z 6.16.z labels Oct 21, 2024
@pnovotny pnovotny self-assigned this Oct 21, 2024
@pnovotny pnovotny requested review from pondrejk, lhellebr and a team October 21, 2024 11:55
@pnovotny pnovotny mentioned this pull request Oct 21, 2024
Merged
@pnovotny pnovotny marked this pull request as ready for review October 21, 2024 12:41
@pnovotny
Copy link
Contributor Author

Robotello PR PRT passed: SatelliteQE/robottelo#15539

@pnovotny pnovotny added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 21, 2024
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 429
Build Status: UNSTABLE
PRT Comment: pytest -k test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt --external-logging
Test Result : ========== 1 failed, 10 deselected, 21 warnings in 1861.16s (0:31:01) ==========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Oct 21, 2024
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k test_positive_host_details_read_templates tests/foreman/ui/test_host.py

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 430
Build Status: SUCCESS
PRT Comment: pytest -k test_positive_host_details_read_templates tests/foreman/ui/test_host.py --external-logging
Test Result : ========== 1 passed, 77 deselected, 89 warnings in 1157.48s (0:19:17) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Oct 21, 2024
@lhellebr
Copy link
Contributor

lhellebr commented Nov 4, 2024

trigger: test-robottelo
pytest: test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation

lhellebr
lhellebr approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran PRT to check whether this breaks something a similar change broke before. If it passes, ACK.

@pnovotny
Copy link
Contributor Author

pnovotny commented Nov 4, 2024

trigger: test-robottelo
pytest: -k test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 438
Build Status: UNSTABLE
PRT Comment: pytest -k test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation --external-logging
Test Result : ========== 1 failed, 11 deselected, 22 warnings in 590.13s (0:09:50) ===========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Nov 4, 2024
@lhellebr
Copy link
Contributor

lhellebr commented Nov 4, 2024 •
edited
Loading

Interesting, the failure is not my added test but a test that passed for you:

tests.foreman.ui.test_ansible.TestAnsibleCfgMgmt.test_positive_non_admin_user_access_with_usergroup

@pnovotny
Copy link
Contributor Author

pnovotny commented Nov 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 440
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_non_admin_user_access_with_usergroup tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates --external-logging
Test Result : ======== 1 failed, 1 passed, 59 warnings, 1 error in 678.15s (0:11:18) =========

@pnovotny
hosts table: fix locator for host Name column (again)
1f33452 
Re-introducing this fix after being reverted.
This commit unintentionally broke navigation to host details page,
which was caused by another issue in the Sat hosts table,
then fixed in 71a745e

Original description:

The `HostsView` Name table column XPath was missing leading '.' character,
which caused that all host rows returned had the same Name value,
equal to the first table row host Name.
@pnovotny pnovotny force-pushed the host-table-name-locator-fix-again branch from 86c4803 to 1f33452 Compare November 19, 2024 18:29
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates

@pnovotny
Copy link
Contributor Author

Rebased. Also excluding test tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_non_admin_user_access_with_usergroup from PRT.

It fails with error TypeError: add_single_ansible_role() takes 2 positional arguments but 3 were given. It's strange because in Sat. stream test execution the test is passing. Nonetheless, this error is not related to this PR and will be handled separately.

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 457
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates --external-logging
Test Result : ================= 2 passed, 58 warnings in 1281.71s (0:21:21) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Nov 19, 2024
@pondrejk pondrejk merged commit 7d85389 into SatelliteQE:master Nov 20, 2024
9 of 10 checks passed
This was referenced Nov 20, 2024
Merged
Merged
Merged
Merged
@pnovotny pnovotny deleted the host-table-name-locator-fix-again branch November 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@pondrejk pondrejk pondrejk approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pnovotny pnovotny

Labels
6.15.z 6.16.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pnovotny @Satellite-QE @lhellebr @pondrejk @LadislavVasina1