Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] hosts table: Name locator fix (again) #1637

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[6.16.z] hosts table: Name locator fix (again) #1637

merged 1 commit into from
Nov 20, 2024

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1603

Problem Statement

Re-introducing this fix after being reverted.
This commit unintentionally broke navigation to host details page,
which was caused by another issue in the Sat hosts table
and fixed in #1465

Description:

The HostsView Name table column XPath was missing leading '.' character,
which caused that all host rows that were returned, had the same Name value,
equal to the first table row host Name.

@pnovotny @web-flow
hosts table: fix locator for host Name column (again)
00c9adc 
Re-introducing this fix after being reverted.
This commit unintentionally broke navigation to host details page,
which was caused by another issue in the Sat hosts table,
then fixed in 71a745e

Original description:

The `HostsView` Name table column XPath was missing leading '.' character,
which caused that all host rows returned had the same Name value,
equal to the first table row host Name.

(cherry picked from commit 7d85389)
@Satellite-QE Satellite-QE added 6.16.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 20, 2024
@Satellite-QE
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing label Nov 20, 2024
@Satellite-QE
Copy link
Contributor Author

PRT Result

Build Number: 459
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py tests/foreman/longrun/test_oscap.py::test_positive_oscap_remediation tests/foreman/ui/test_host.py::test_positive_host_details_read_templates --external-logging
Test Result : ================= 2 passed, 58 warnings in 1277.90s (0:21:17) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 20, 2024
@Satellite-QE Satellite-QE merged commit 9e43113 into 6.16.z Nov 20, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnovotny pnovotny

Labels
6.16.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @pnovotny