fix(blink): allow arbitrary audio channels #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akers and microphone
…ported configuration
…ardware. audio hardware doesn't care about the codec. the user doesn't care about the mime type and sample rate
…rary channels for hardware
average the audio channels in the callback remove the ChannelMixer from Framer
dariusc93
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
This PR improves the way audio channels are handled. Now for webrtc communication, only one audio channel is used. Blink now allows microphones and speakers with arbitrary number of channels.
Audio hardware is represented using a new struct instead of an
AudioCodec, because a speaker/microphone doesn't care about the MIME type - it only deals in raw samples.The
AudioCodecstruct no longer has a field for channels because for webrtc communication, only one channel is used.This PR also changes the way audio hardware is tested. Blink no longer performs that task, but instead returns a new struct:
AudioDeviceConfig, which lets the user view, select, and test speaker/microphone combinations. The user can then pass that struct back to blink to apply said configuration.There was one change to RayGun because I was getting a compiler error. I believe it has no effect on behavior.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤