feat(blink): add capability to test audio devices #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
The audio device configuration is now represented as a
AudioDeviceConfigwhich abstracts the behavior needed to enumerate speakers/microphones and interact with them. The library user can obtain aAudioDeviceConfigfrom Blink, view the currently selected speaker/microphone, enumerate speakers/microphones, and select/test combinations of them. The library user can then send the modifiedAudioDeviceConfigback to Blink, telling it to use the selected speaker/microphone.The main point of this is to let the user test their speaker and microphone. The rest is just a refactor. Hopefully it's an improvement but if not I can change the Blink API back to what it was before.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤