Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for atomicv on CXI #1147

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix for atomicv on CXI #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de970c3
Fix for atomicv on CXI
wrrobin Sep 18, 2024
997a631
Removing periodic quiet
wrrobin Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/shmem_comm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,12 +336,7 @@ shmem_internal_atomicv(shmem_ctx_t ctx, void *target, const void *source,
shmem_internal_fetch_atomic(ctx, ((uint8_t *) target) + (i * type_size),
((uint8_t *) source) + (i * type_size), &tmp_fetch, type_size,
pe, op, datatype);
#ifdef SOS_OFI_CXI_QUIET_RATE
/* FIXME: This intermittent quiet should not be required: */
if (i % SOS_OFI_CXI_QUIET_RATE == 0) {
shmem_transport_put_quiet((shmem_transport_ctx_t *)ctx);
}
#endif
shmem_transport_get_wait((shmem_transport_ctx_t *)ctx);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this outside the loop over count? I don't quite see why we need to wait after every atomic?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we cant as the loop itself can go beyond the number of atomics that causes the issue on CXI.

}
*completion += 1;
#else
Expand Down
7 changes: 0 additions & 7 deletions src/transport_ofi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@
#define ENABLE_TARGET_CNTR 0
#endif

#if DISABLE_NONFETCH_AMO
/* FIXME: The progress of back-to-back atomic ops over CXI is improved with an
* occasional quiet operation. This constant sets the number of atomic ops that
* occur between calls to quiet within shmem_internal_atomicv. */
#define SOS_OFI_CXI_QUIET_RATE 200
#endif

#if ENABLE_TARGET_CNTR
extern struct fid_cntr* shmem_transport_ofi_target_cntrfd;
#endif
Expand Down
Loading