Fix for atomicv on CXI #1147
Merged
Fix for atomicv on CXI #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidozog
reviewed
Sep 18, 2024
| @@ -336,6 +336,7 @@ shmem_internal_atomicv(shmem_ctx_t ctx, void *target, const void *source, | |||
| shmem_internal_fetch_atomic(ctx, ((uint8_t *) target) + (i * type_size), | |||
| ((uint8_t *) source) + (i * type_size), &tmp_fetch, type_size, | |||
| pe, op, datatype); | |||
| shmem_transport_get_wait((shmem_transport_ctx_t *)ctx); | |||
There was a problem hiding this comment.
Can we move this outside the loop over count? I don't quite see why we need to wait after every atomic?
There was a problem hiding this comment.
Nope, we cant as the loop itself can go beyond the number of atomics that causes the issue on CXI.
src/shmem_comm.h
Outdated
| @@ -336,6 +336,7 @@ shmem_internal_atomicv(shmem_ctx_t ctx, void *target, const void *source, | |||
| shmem_internal_fetch_atomic(ctx, ((uint8_t *) target) + (i * type_size), | |||
| ((uint8_t *) source) + (i * type_size), &tmp_fetch, type_size, | |||
| pe, op, datatype); | |||
| shmem_transport_get_wait((shmem_transport_ctx_t *)ctx); | |||
| #ifdef SOS_OFI_CXI_QUIET_RATE | |||
There was a problem hiding this comment.
Is there any chance we can remove this after the above fix?
There was a problem hiding this comment.
I think based on the atomic OP, we cant get rid of this completely. But, will check.
davidozog
approved these changes
Sep 19, 2024
davidozog
pushed a commit
to davidozog/sandia-shmem
that referenced
this pull request
Oct 9, 2024
* Fix for atomicv on CXI * Removing periodic quiet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.