Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-848] Query for id only #39

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[IBCDPE-848] Query for id only #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5ceab6
Query for id only
jaymedina Mar 19, 2024
a8ec7da
Keep index of id
jaymedina Mar 19, 2024
e192e6e
Updated mock tableQuery call in test_ops.py
jaymedina Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/orca/services/synapse/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def get_submissions_with_status(

# Get all submissions for the given ``submission_view``
query_results = self.client.tableQuery(
f"select * from {submission_view} where status = '{submission_status}'"
f"select id from {submission_view} where status = '{submission_status}'"
)

submission_ids = query_results.asDataFrame()["id"].tolist()
Expand Down
2 changes: 1 addition & 1 deletion tests/services/synapse/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def test_get_submissions_with_status(

# Assertions
syn_mock.tableQuery.assert_called_once_with(
f"select * from {submission_view} where status = '{submission_status}'"
f"select id from {submission_view} where status = '{submission_status}'"
)
table_mock.asDataFrame.assert_called()
assert result == input_dict["id"]
Expand Down
Loading