Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-848] Query for id only #39

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[IBCDPE-848] Query for id only #39

merged 3 commits into from
Mar 20, 2024

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Mar 19, 2024

problem

It's unnecessary to query for all the columns in a Synapse table view if the only column of interest is the Submission ID.

solution

Select only the id column in the tableQuery call, and have the mock tableQuery call reflect this in the tests.

testing & preview

Unit tests still passing with these changes, so behavior is as expected.

@jaymedina jaymedina self-assigned this Mar 19, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (63575a2) to head (e192e6e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          932       932           
  Branches       141       141           
=========================================
  Hits           932       932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaymedina jaymedina changed the title Query for id only [IBCDPE-848] Query for id only Mar 20, 2024
@jaymedina jaymedina added the enhancement New feature or request label Mar 20, 2024
@jaymedina jaymedina marked this pull request as ready for review March 20, 2024 00:13
@jaymedina jaymedina requested a review from a team as a code owner March 20, 2024 00:13
@jaymedina jaymedina requested a review from BryanFauble March 20, 2024 00:16
@jaymedina jaymedina merged commit 959e33b into main Mar 20, 2024
11 checks passed
@jaymedina jaymedina deleted the IBCDPE-848-query-id-only branch March 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants