Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unknown operation system build #7398

Closed
wants to merge 2 commits into from
Closed

Allow unknown operation system build #7398

wants to merge 2 commits into from

Commits on Jun 3, 2024

  1. Add missing debian operation system in help string 

    The commit e6ae55d has added the debian
operating system, but the help string does not reflect it yet.

This adds the missing debian entry in the help string.

See:

	gportay@archlinux ~/src/sssd $ ./configure --help | grep -A1 with-os
	  --with-os=OS_TYPE       Type of your operation system
	                          (fedora|redhat|suse|debian|gentoo)

Signed-off-by: Gaël PORTAY <[email protected]>
    @gportay
    gportay committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3d310e1 View commit details
    Browse the repository at this point in the history

  2. Allow unknown operation system build 

    There are various operating systems in the world, and there are even
more if considering the embedded world.

Trying to detect all of them is hardwork and unnecessary.

If the host operating system is uncaught, the configure succeeds with
the following incomplete output:

	./configure
	(...)
	configure: Detected operating system type:
	configure: Build with  config
	---------------------^^

This enables the operating system "unknown" to remove the error raised
and to allow setting a system that is the short list.

It allows the use for options --with-os=unknown or --with-os=arch that
are a often more representative if the operating system is not in the
short list.

It turns:

	./configure --with-os=unknown
	(...)
	configure: error: Illegal value -unknown- for option --with-os

Into:

	./configure --with-os=unknown
	configure: Detected operating system type: unknown
	configure: Build with unknown config

Also, it avoids the assumption the target operating system is the same
as host if cross-compiling, and leads to errors.

For example, the commit e6ae55d passes
the downstream debian option --install-layout=deb to setup.py and raises
an error if targetting a non-debian world (such as openembedded).

Fixes:

	error: option --install-layout not recognized

Signed-off-by: Gaël PORTAY <[email protected]>
    @gportay
    gportay committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    56b3200 View commit details
    Browse the repository at this point in the history