Allow unknown operation system build #7398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
Waiting for review
no-backport
pbrezina
approved these changes
May 31, 2024
alexey-tikhonov
added
Ready to push
|
@gportay, hi. Could you please rebase? |
The commit e6ae55d has added the debian operating system, but the help string does not reflect it yet. This adds the missing debian entry in the help string. See: gportay@archlinux ~/src/sssd $ ./configure --help | grep -A1 with-os --with-os=OS_TYPE Type of your operation system (fedora|redhat|suse|debian|gentoo) Signed-off-by: Gaël PORTAY <[email protected]>
There are various operating systems in the world, and there are even more if considering the embedded world. Trying to detect all of them is hardwork and unnecessary. If the host operating system is uncaught, the configure succeeds with the following incomplete output: ./configure (...) configure: Detected operating system type: configure: Build with config ---------------------^^ This enables the operating system "unknown" to remove the error raised and to allow setting a system that is the short list. It allows the use for options --with-os=unknown or --with-os=arch that are a often more representative if the operating system is not in the short list. It turns: ./configure --with-os=unknown (...) configure: error: Illegal value -unknown- for option --with-os Into: ./configure --with-os=unknown configure: Detected operating system type: unknown configure: Build with unknown config Also, it avoids the assumption the target operating system is the same as host if cross-compiling, and leads to errors. For example, the commit e6ae55d passes the downstream debian option --install-layout=deb to setup.py and raises an error if targetting a non-debian world (such as openembedded). Fixes: error: option --install-layout not recognized Signed-off-by: Gaël PORTAY <[email protected]>
gportay
force-pushed
the
allow-unknown-operation-system-build
branch
from
81cfeb7
to
56b3200
Compare
done. |
|
looks good (the same) after rebase 👍 |
gportay
added a commit
to gportay/meta-security
that referenced
this pull request
Oct 21, 2024
The configure script guesses the target system from the host if no --with-os= is set[1]. It is untrue if cross-compiling. The guessed host operating system is used then to do specific things fort target build. The commit[2] passes the downstream debian option --install-layout=deb to setup.py[3] if the host system is debian based, and thus, it raises the error attached below as that debian-specific option[4] is not part of the openembedded[5] world. This sets the Fedora operating system thanks to the existing configure option --with-os=fedora, that is relatively sain operating system for the needs of openembedded. Fixes: | (...)/build/tmp/work/aarch64-poky-linux/sssd/2.5.2-r0/build/src/config/setup.py:25: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives | from distutils.core import setup | usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] | or: setup.py --help [cmd1 cmd2 ...] | or: setup.py --help-commands | or: setup.py cmd --help | | error: option --install-layout not recognized | Traceback (most recent call last): | File "/home/gportay/src/openembedded-tests/build/tmp/work/core2-64-poky-linux/sssd/2.9.2/build/src/config/setup.py", line 25, in <module> | from distutils.core import setup | ModuleNotFoundError: No module named 'distutils' Note: Upstream has introduced the "unknown" operating systemd with the upcoming version 2.10.0[6][7]. The change can be backported. [1]: https://github.com/SSSD/sssd/blob/2.5.2/src/external/platform.m4#L1-L31 [2]: SSSD/sssd@e6ae55d [3]: https://github.com/SSSD/sssd/blob/2.5.2/Makefile.am#L32-L35 [4]: https://sources.debian.org/patches/setuptools/68.1.2-2/install-layout.diff/#L7 [5]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3-setuptools_59.5.0.bb?h=kirkstone [6]: SSSD/sssd@7b32dc0 [7]: SSSD/sssd#7398 Signed-off-by: Gaël PORTAY <[email protected]>
doanac
pushed a commit
to lmp-mirrors/meta-security
that referenced
this pull request
Nov 4, 2024
The configure script guesses the target system from the host if no --with-os= is set[1]. It is untrue if cross-compiling. The guessed host operating system is used then to do specific things fort target build. The commit[2] passes the downstream debian option --install-layout=deb to setup.py[3] if the host system is debian based, and thus, it raises the error attached below as that debian-specific option[4] is not part of the openembedded[5] world. This sets the Fedora operating system thanks to the existing configure option --with-os=fedora, that is relatively sain operating system for the needs of openembedded. Fixes: | (...)/build/tmp/work/aarch64-poky-linux/sssd/2.5.2-r0/build/src/config/setup.py:25: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives | from distutils.core import setup | usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] | or: setup.py --help [cmd1 cmd2 ...] | or: setup.py --help-commands | or: setup.py cmd --help | | error: option --install-layout not recognized | Traceback (most recent call last): | File "/home/gportay/src/openembedded-tests/build/tmp/work/core2-64-poky-linux/sssd/2.9.2/build/src/config/setup.py", line 25, in <module> | from distutils.core import setup | ModuleNotFoundError: No module named 'distutils' Note: Upstream has introduced the "unknown" operating systemd with the upcoming version 2.10.0[6][7]. The change can be backported. [1]: https://github.com/SSSD/sssd/blob/2.5.2/src/external/platform.m4#L1-L31 [2]: SSSD/sssd@e6ae55d [3]: https://github.com/SSSD/sssd/blob/2.5.2/Makefile.am#L32-L35 [4]: https://sources.debian.org/patches/setuptools/68.1.2-2/install-layout.diff/#L7 [5]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3-setuptools_59.5.0.bb?h=kirkstone [6]: SSSD/sssd@7b32dc0 [7]: SSSD/sssd#7398 Signed-off-by: Gaël PORTAY <[email protected]> Signed-off-by: Armin Kuster <[email protected]>
offa
pushed a commit
to jhnc-oss/meta-security
that referenced
this pull request
Nov 25, 2024
The configure script guesses the target system from the host if no --with-os= is set[1]. It is untrue if cross-compiling. The guessed host operating system is used then to do specific things fort target build. The commit[2] passes the downstream debian option --install-layout=deb to setup.py[3] if the host system is debian based, and thus, it raises the error attached below as that debian-specific option[4] is not part of the openembedded[5] world. This sets the Fedora operating system thanks to the existing configure option --with-os=fedora, that is relatively sain operating system for the needs of openembedded. Fixes: | (...)/build/tmp/work/aarch64-poky-linux/sssd/2.5.2-r0/build/src/config/setup.py:25: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives | from distutils.core import setup | usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] | or: setup.py --help [cmd1 cmd2 ...] | or: setup.py --help-commands | or: setup.py cmd --help | | error: option --install-layout not recognized | Traceback (most recent call last): | File "/home/gportay/src/openembedded-tests/build/tmp/work/core2-64-poky-linux/sssd/2.9.2/build/src/config/setup.py", line 25, in <module> | from distutils.core import setup | ModuleNotFoundError: No module named 'distutils' Note: Upstream has introduced the "unknown" operating systemd with the upcoming version 2.10.0[6][7]. The change can be backported. [1]: https://github.com/SSSD/sssd/blob/2.5.2/src/external/platform.m4#L1-L31 [2]: SSSD/sssd@e6ae55d [3]: https://github.com/SSSD/sssd/blob/2.5.2/Makefile.am#L32-L35 [4]: https://sources.debian.org/patches/setuptools/68.1.2-2/install-layout.diff/#L7 [5]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3-setuptools_59.5.0.bb?h=kirkstone [6]: SSSD/sssd@7b32dc0 [7]: SSSD/sssd#7398 Signed-off-by: Gaël PORTAY <[email protected]> Signed-off-by: Armin Kuster <[email protected]>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Nov 25, 2024
The configure script guesses the target system from the host if no --with-os= is set[1]. It is untrue if cross-compiling. The guessed host operating system is used then to do specific things fort target build. The commit[2] passes the downstream debian option --install-layout=deb to setup.py[3] if the host system is debian based, and thus, it raises the error attached below as that debian-specific option[4] is not part of the openembedded[5] world. This sets the Fedora operating system thanks to the existing configure option --with-os=fedora, that is relatively sain operating system for the needs of openembedded. Fixes: | (...)/build/tmp/work/aarch64-poky-linux/sssd/2.5.2-r0/build/src/config/setup.py:25: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives | from distutils.core import setup | usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] | or: setup.py --help [cmd1 cmd2 ...] | or: setup.py --help-commands | or: setup.py cmd --help | | error: option --install-layout not recognized | Traceback (most recent call last): | File "/home/gportay/src/openembedded-tests/build/tmp/work/core2-64-poky-linux/sssd/2.9.2/build/src/config/setup.py", line 25, in <module> | from distutils.core import setup | ModuleNotFoundError: No module named 'distutils' Note: Upstream has introduced the "unknown" operating systemd with the upcoming version 2.10.0[6][7]. The change can be backported. [1]: https://github.com/SSSD/sssd/blob/2.5.2/src/external/platform.m4#L1-L31 [2]: SSSD/sssd@e6ae55d [3]: https://github.com/SSSD/sssd/blob/2.5.2/Makefile.am#L32-L35 [4]: https://sources.debian.org/patches/setuptools/68.1.2-2/install-layout.diff/#L7 [5]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3-setuptools_59.5.0.bb?h=kirkstone [6]: SSSD/sssd@7b32dc0 [7]: SSSD/sssd#7398 Signed-off-by: Gaël PORTAY <gael.portay+rtonegmail.com> Signed-off-by: Armin Kuster <akuster808gmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
Nov 25, 2024
The configure script guesses the target system from the host if no --with-os= is set[1]. It is untrue if cross-compiling. The guessed host operating system is used then to do specific things fort target build. The commit[2] passes the downstream debian option --install-layout=deb to setup.py[3] if the host system is debian based, and thus, it raises the error attached below as that debian-specific option[4] is not part of the openembedded[5] world. This sets the Fedora operating system thanks to the existing configure option --with-os=fedora, that is relatively sain operating system for the needs of openembedded. Fixes: | (...)/build/tmp/work/aarch64-poky-linux/sssd/2.5.2-r0/build/src/config/setup.py:25: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives | from distutils.core import setup | usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] | or: setup.py --help [cmd1 cmd2 ...] | or: setup.py --help-commands | or: setup.py cmd --help | | error: option --install-layout not recognized | Traceback (most recent call last): | File "/home/gportay/src/openembedded-tests/build/tmp/work/core2-64-poky-linux/sssd/2.9.2/build/src/config/setup.py", line 25, in <module> | from distutils.core import setup | ModuleNotFoundError: No module named 'distutils' Note: Upstream has introduced the "unknown" operating systemd with the upcoming version 2.10.0[6][7]. The change can be backported. [1]: https://github.com/SSSD/sssd/blob/2.5.2/src/external/platform.m4#L1-L31 [2]: SSSD/sssd@e6ae55d [3]: https://github.com/SSSD/sssd/blob/2.5.2/Makefile.am#L32-L35 [4]: https://sources.debian.org/patches/setuptools/68.1.2-2/install-layout.diff/#L7 [5]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python3-setuptools_59.5.0.bb?h=kirkstone [6]: SSSD/sssd@7b32dc0 [7]: SSSD/sssd#7398 Signed-off-by: Gaël PORTAY <gael.portay+rtonegmail.com> Signed-off-by: Armin Kuster <akuster808gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Maintainers,
I faces an issue if I cross-compile the project for OpenEmbedded from a Debian build system, with python.
I get the following:
The
configurescript guesses the target system from the host if no--with-os=is set. It is untrue if cross-compiling.Setting an operation system that is unsupported (i.e. not
fedora, notredhatnotsuse, notdebianor notgentoo) raises an error:In some circumstances, it is preferable to ignore an unsupported operation system and just do nothing.
This (second) patch adds the operation system
unknownto avoid theconfigurescript to guess for which operating system the project is build for; this also improve the incomplete output:Regards,
Gaël