Merge Ext Teledyne Test #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having an issue with decoding the serial port
still having error making command instance
starts after modem boots FEAT: added deep logging for every part of this test TODO: closes threads non-gracefully (may need to look at using something else for displaying output)
[TODO] need to test with live serial port
…aths [FEAT] wrote setup.sh that make scripts executable and adds scripts into services to autostart modem test on boot and show log when user logs in [FEAT] changed the order of timings to wait till pi fully boots up [FEAT] made a bash script that runs the python script to display the logs [FEAT] added basic instructions in README to setup autostart on a pi [TODO] find a way to define the home directory in the service instead of explicitly writing it out
oldstylejoe
reviewed
Aug 22, 2024
There was a problem hiding this comment.
recommend to add .DS_Store and remove the .DS_Store files from the branch. Also, remove pycache from the commit.
✅ Deploy Preview for teledyne-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested Code on pi with modems connected (including all setup and autostart scripts) and everything seems to work fine
Changes:
[TODO] need to work on closing the threads more gracefully in
modem_test_clam_shell.py