Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #426 | Create dataset loader for CLIRMatrix #650

Merged
merged 6 commits into from
May 30, 2024

Conversation

fhudi
Copy link
Collaborator

@fhudi fhudi commented Apr 17, 2024

Closes #426

source-only dataloader.

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Note:

  • As this dataloader is source-only, seacrowd schema is not implemented.
  • test was done using tests.test_seacrowd_source_only.py.

Copy link
Contributor

@holylovenia holylovenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fhudi, thanks a lot for your hard work for this dataloader. I have some suggestions and questions:

seacrowd/sea_datasets/clir_matrix/clir_matrix.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/clir_matrix/clir_matrix.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/clir_matrix/clir_matrix.py Outdated Show resolved Hide resolved
@holylovenia holylovenia requested review from luckysusanto and removed request for jensan-1 May 13, 2024 08:51
@holylovenia holylovenia assigned luckysusanto and unassigned jensan-1 May 13, 2024
Copy link
Contributor

@holylovenia holylovenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, @fhudi! Aside from another comment request above, it works well. I'm approving this PR.

Let's wait for @luckysusanto's review.

@holylovenia holylovenia requested review from muhammadravi251001 and removed request for luckysusanto May 30, 2024 03:37
@holylovenia
Copy link
Contributor

Hi @muhammadravi251001, I assigned you in place of @luckysusanto due to the lack of response.

I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.

@muhammadravi251001
Copy link
Collaborator

Hi @muhammadravi251001, I assigned you in place of @luckysusanto due to the lack of response.

I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.

Alright kak Holy, I will try my best. Maybe I will finish it at 2.00 PM on Jakarta time kak!

Copy link
Collaborator

@muhammadravi251001 muhammadravi251001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. LGTM. Thanks for the contribution @fhudi!

@muhammadravi251001 muhammadravi251001 merged commit a06c609 into SEACrowd:master May 30, 2024
1 check passed
@fhudi fhudi deleted the dl-clir_matrix branch May 31, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for CLIRMatrix
6 participants