Closes #53 | Implement dataloader for IndoCamRest #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanalkautsar
requested review from
holylovenia,
SamuelCahyawijaya,
sabilmakbar,
jamesjaya,
yongzx,
gentaiscool,
ljvmiranda921,
RosenZhang and
fajri91
as code owners
holylovenia
removed request for
gentaiscool,
SamuelCahyawijaya,
fajri91,
ljvmiranda921,
RosenZhang,
yongzx and
sabilmakbar
holylovenia
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Hi @dehanalkautsar, LGTM! The dataloader works well. I need you to remove the changes to constant.py and schemas/ though.
|
Okay @holylovenia, those changes have been removed👍 |
holylovenia
approved these changes
Jan 18, 2024
jamesjaya
approved these changes
Jan 18, 2024
raileymontalan
pushed a commit
to raileymontalan/seacrowd-datahub
that referenced
this pull request
Feb 28, 2024
* feat: add dataloader indocamrest for source * refactor: indocamrest by pre-commit * remove __name__:__main__ on indocamrest * fix the license constant in IndoCamrest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53.
Note
turn_labelfield in this dataloader as an empty array because this dataset does not have them.Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py(please use only lowercase and underscore for dataset naming)._CITATION,_DATASETNAME,_DESCRIPTION,_HOMEPAGE,_LICENSE,_URLs,_SUPPORTED_TASKS,_SOURCE_VERSION, and_SEACROWD_VERSIONvariables._info(),_split_generators()and_generate_examples()in dataloader script.BUILDER_CONFIGSclass attribute is a list with at least oneSEACrowdConfigfor the source schema and one for a seacrowd schema.datasets.load_datasetfunction.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.