-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Schema: End-to-end Task-oriented Dialogue System (WoZ) #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dehanalkautsar, thanks for the schema!! It's really helpful since we didn't have any dialogue schema previously. @holylovenia and I have some suggestions regarding this schema:
- Change the task and schema name to E2E_TASK_ORIENTED_DIALOGUE and TOD (tod.py).
- Remove the unrelated changes, e.g., PhoATIS, from the PR.
- Remove the
asr
field from the schema. - Change the system_transcript field to system_utterance.
- Change the transcript field to user_utterance.
Please let us know if you have any questions.
Hi @SamuelCahyawijaya, I agree with your suggestions and have implemented the schema based on your suggestions. Let me know if you have any points that need to be discussed. |
Hi @dehanalkautsar, thanks for implementing this; really helpful for SEACrowd ToD Datasets going forward. A couple of comments on docstring consistency:
|
Hi @sabilmakbar , oh yeah, sorry I forgot about that. I have fixed the docstring and it should be correct now. Thanks for your input! |
Hi @holylovenia @SamuelCahyawijaya, do you have any additional comments on this? So far, it looks good to me. btw @dehanalkautsar, have you tried to temporarily add the codebase and implement it to the dataloader of yours? |
Yes I have @sabilmakbar. Actually I've created PRs for those dataloaders using this schema (#257, #258, #261) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @dehanalkautsar. Looks good to me!! 🍾 I'll ping @SamuelCahyawijaya to get his opinion ASAP. If he gives the okay, then we can merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @dehanalkautsar , LGTM!
Let's merge this, then! |
Closes #172 .
Note