-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related #16 | Add Tree schema and CONSTITUENCY_PARSING task #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the new schema @MJonibek. LGTM!
\\ | ||
NODE3 ..... | ||
""" | ||
import datasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, ok I will do it today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I tried to do small example, because all sentences from alt_burmese_tree_bank dataset are big. I think now it is clear how to use this schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so the dataset construction from the example sentence will be a top-down approach then, I thought it was a bottom-up. Looks fine to me, thanks a lot for proposing + implementing this, @MJonibek!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's wait for @SamuelCahyawijaya's review for this. Prior to merging, pls pull the changes first that has happened in master
branch, @MJonibek.
\\ | ||
NODE3 ..... | ||
""" | ||
import datasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so the dataset construction from the example sentence will be a top-down approach then, I thought it was a bottom-up. Looks fine to me, thanks a lot for proposing + implementing this, @MJonibek!
Related #16
Note: