Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): fdp table - make responsive pop-in areas navigable #12673

Merged
merged 9 commits into from
Jan 3, 2025
Merged

feat(platform): fdp table - make responsive pop-in areas navigable #12673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
22ef39b
feat(platform): fdp table - make responsive pop-in areas navigable
khotcholava Oct 30, 2024
a8a8f2e
feat(platform): fdp table - make responsive pop-in areas navigable
khotcholava Oct 30, 2024
e0c835b
Merge branch 'main' into 11004-make-responsive-pop-in-are-clickable
khotcholavaSuzy Nov 26, 2024
83ae1b4
fix(core): wizard section role
khotcholavaSuzy Nov 26, 2024
d54d734
feat(platform): table responsive pop-in hover
khotcholava Dec 4, 2024
3084e1f
fix(platform): resolve row hover visual glitch
khotcholava Dec 9, 2024
6bd8c76
Merge branch 'main' into 11004-make-responsive-pop-in-are-clickable
khotcholava Dec 20, 2024
ad0d7c3
Merge branch 'main' into 11004-make-responsive-pop-in-are-clickable
mikerodonnell89 Jan 2, 2025
968860d
fix(platform): only use cursor pointer for activable secondary rows
mikerodonnell89 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libs/platform/table/table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
</div>
@if (showGrowingButton) {
<fdp-table-growing-button [showItemsCount]="showItemsCount" [showItemsCount]="true"></fdp-table-growing-button>
mikerodonnell89 marked this conversation as resolved.
Show resolved Hide resolved
<fdp-table-growing-button [showItemsCount]="showItemsCount"></fdp-table-growing-button>
}
</fd-busy-indicator>
<!-- Table Template -->
Expand Down Expand Up @@ -131,6 +131,9 @@
}
@if (row.type === 'item' && _tableService.poppingColumns$().length > 0) {
<tr
(keydown.enter)="_onRowClick(row, $event)"
(keydown.space)="_onRowClick(row, $event)"
(click)="_onRowClick(row, $event)"
fdp-table-popping-row
[secondary]="true"
[style.height.px]="secondaryRowHeight"
Expand Down
1 change: 1 addition & 0 deletions libs/platform/table/table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ fdk-dynamic-portal {
&__body-table {
&.fd-table--pop-in {
.fd-table__row--secondary {
cursor: pointer;
mikerodonnell89 marked this conversation as resolved.
Show resolved Hide resolved
.fd-table__cell {
border-bottom: var(--sapList_BorderWidth) solid var(--sapList_BorderColor);

Expand Down