Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform): fdp table - make responsive pop-in areas navigable #12673

Merged
merged 9 commits into from
Jan 3, 2025
Merged

feat(platform): fdp table - make responsive pop-in areas navigable #12673

merged 9 commits into from
Jan 3, 2025

Conversation

khotcholava
Copy link
Contributor

feat(platform): fdp table - make responsive pop-in areas navigable

closes #11004

Description

  • Ensure row navigation works correctly when interacting with pop-in columns using fdpTableColumnResponsive.
  • Malfunction code: showItemsCount input was duplicated.

@khotcholava
feat(platform): fdp table - make responsive pop-in areas navigable
22ef39b 
closes [#11004](#11004)

## Description
Ensure row navigation works correctly when interacting with pop-in columns using `fdpTableColumnResponsive`.
@khotcholava
feat(platform): fdp table - make responsive pop-in areas navigable
a8a8f2e 
closes [#11004](#11004)

## Description
Malfunction code: `showItemsCount` input was duplicated.
@khotcholava khotcholava self-assigned this Oct 30, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 968860d
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6776e2f848b58f0008ac5fa0
😎 Deploy Preview https://deploy-preview-12673--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 968860d):

https://fundamental-ngx-gh--pr12673-11004-make-responsiv-oln2yblt.web.app

(expires Mon, 06 Jan 2025 14:20:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@droshev droshev added this to the Sprint 139 - October 2024 milestone Oct 30, 2024
@droshev droshev added the table label Oct 30, 2024
@droshev droshev requested a review from a team October 30, 2024 11:36
mikerodonnell89
mikerodonnell89 previously requested changes Nov 4, 2024
View reviewed changes
libs/platform/table/table.component.scss Outdated Show resolved Hide resolved
@droshev
Copy link
Contributor

droshev commented Nov 20, 2024

@khotcholava to follow up

@droshev droshev requested review from mikerodonnell89 and a team November 26, 2024 14:46
@khotcholava
feat(platform): table responsive pop-in hover
d54d734 
- Changed class name with more appropriate name
@mikerodonnell89
Copy link
Member

Couple things:

  • Border here is now missing
    Screenshot 2024-12-05 at 11 14 12 AM

  • When an item is selected and then i hover the description area, hover state is only applied to the title area. You can see the title area has a grey background and the description area has a blue background in the screenshot above

  • Description header text ("Description (popping < 900px)") is still receiving text selection cursor, implying clicking the area is not actionable

@khotcholava
fix(platform): resolve row hover visual glitch
3084e1f 
closes [#11004](#11004)

Adjust hover logic to prevent highlighting on checked rows, ensuring consistent UI behavior.
@khotcholava khotcholava force-pushed the 11004-make-responsive-pop-in-are-clickable branch from 3bad9c0 to 3084e1f Compare December 11, 2024 13:10
@droshev
Copy link
Contributor

droshev commented Dec 18, 2024

@dpavlenishvili can you review it? thanks

@droshev
Copy link
Contributor

droshev commented Dec 20, 2024

@mikerodonnell89 Can you take it from here. According to Akaki the work is done.

@mikerodonnell89 mikerodonnell89 merged commit 38cf776 into main Jan 3, 2025
19 checks passed
@mikerodonnell89 mikerodonnell89 deleted the 11004-make-responsive-pop-in-are-clickable branch January 3, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpavlenishvili dpavlenishvili dpavlenishvili approved these changes

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

Assignees

@mikerodonnell89 mikerodonnell89

@khotcholava khotcholava

Labels
table
Projects
None yet
Milestone
Sprint 141 - December 2024
Development

Successfully merging this pull request may close these issues.

[enhancement] fdp table - make responsive pop-in areas navigatable
5 participants
@khotcholava @droshev @mikerodonnell89 @dpavlenishvili @khotcholavaSuzy