Refer to containers/ subfolder and the correct path in example #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
approved these changes
May 23, 2024
There was a problem hiding this comment.
Worked for me +1
curious what would need to change for the more idiomatic code/containers pattern to function.
nothing in https://github.com/ReproNim/ds000003-demo jumped out at me
|
Do you remember how you could have come up with care to submit a PR (with testing step by step manually) for moving under code/containers? |
There is no ~/top-level-dataset/ Even though we should migrate to use code/containers, current example does not so copy pasting individual commands does not work. The monolythic script is ok
Interestingly it does not fail shellcheck locally but does on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no ~/top-level-dataset/
Even though we should migrate to use code/containers, current example does not so copy pasting individual commands does not work. The monolythic script is ok