Convert freeze_versions to Python
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
requested changes
Nov 14, 2023
scripts/freeze_versions
Outdated
| echo "Unknown option '$arg'" >&2 | ||
| exit 5 | ||
| esac | ||
| for arg in sys.argv[1:]: |
There was a problem hiding this comment.
Could you please right away rf it to use built in argparse
Co-authored-by: Yaroslav Halchenko <[email protected]>
|
@yarikoptic Ping. |
1 similar comment
|
@yarikoptic Ping. |
|
Thank you @jwodder ! Let's proceed -- I guess I will test/try/fix in the battlefield. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101.
This is just a direct translation. There is various room for improvement of the code quality, but that can come later.