-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis to GitHub Actions #99
Conversation
@yarikoptic The tests are failing on macOS because the dummy Docker script isn't being passed the arguments it expects during the script tests. Instead of a command line ending with:
it's getting:
Also, shellcheck is printing out a bunch of messages, but it's still exiting 0, so no one will ever check to see them. |
1d8dcb6
to
d667a1d
Compare
@yarikoptic I've fixed the shellcheck issue, though I had to skip checking of |
Awesome, thank you! And that script was one trick pony anyways |
ok, one problem as identified by tests
happening on OSX, according to jitterbit/get-changed-files#15 (comment) 👍
but I would like to avoid that since then OSX folks might be left behind... will think about it... |
@yarikoptic The |
rebased, force pushed. |
…ere is no .lexists :-/
While at it also added some informative warnings and some debug printout to enable if needed
Solution provided by chatgpt. The reason is that OSX has elderly bash 3.2.57 (due to licensing issue) which has no mapfile. On Debian I have 5.2.21 now
It was used "actively" and worked splendid. Commenting out so we do not end up running it regularly since it would wait us to login.
… as well Apparently that test was "always" skipped, so we will just do the same on github actions for now
ok, green now (after we just started to skip here too ;) ) -- so let's merge and consider "DONE" ;) |
Closes #98.