Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis to GitHub Actions #99

Merged
merged 13 commits into from
May 1, 2024
Merged

Switch from Travis to GitHub Actions #99

merged 13 commits into from
May 1, 2024

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 25, 2023

Closes #98.

@jwodder
Copy link
Collaborator Author

jwodder commented May 25, 2023

@yarikoptic The tests are failing on macOS because the dummy Docker script isn't being passed the arguments it expects during the script tests. Instead of a command line ending with:

--pwd /singularity 'foo bar' blah 45.5 /dir 'bar;' 'foo&' '\${foo}'

it's getting:

--pwd '/tmp/tmp dir.XXXXXX.cieII6oF' /Users/runner/work/containers/containers/scripts/tests/arg-test.simg sh -c 'find /tmp /var/tmp && cat "/tmp/tmp dir.XXXXXX.cieII6oF/file"'

Also, shellcheck is printing out a bunch of messages, but it's still exiting 0, so no one will ever check to see them.

@jwodder jwodder force-pushed the gh-98 branch 2 times, most recently from 1d8dcb6 to d667a1d Compare May 30, 2023 15:57
@jwodder
Copy link
Collaborator Author

jwodder commented May 30, 2023

@yarikoptic I've fixed the shellcheck issue, though I had to skip checking of scripts/utils/get-rid-of-datalad-remote.sh, which is a zsh script, which shellcheck does not support.

@yarikoptic
Copy link
Member

yarikoptic commented May 30, 2023

Awesome, thank you! And that script was one trick pony anyways

@yarikoptic
Copy link
Member

ok, one problem as identified by tests

line 130: mapfile: command not found

happening on OSX, according to jitterbit/get-changed-files#15 (comment) 👍

The problem is that macOS has bash 3 and mapfile was introduced in bash 4.
I found a solution, add this step in front in your workflow:

- if: contains( matrix.os, 'macos')
  name: Install bash 5.0 under macOS for mapfile
  run: |
    brew install bash
    sudo mv /usr/local/bin/bash /bin/bash

but I would like to avoid that since then OSX folks might be left behind... will think about it...

@jwodder
Copy link
Collaborator Author

jwodder commented Nov 14, 2023

@yarikoptic The mapfile thing is addressed by #105. The remaining, bigger problem is still #99 (comment).

@yarikoptic
Copy link
Member

rebased, force pushed.

It was used "actively" and worked splendid. Commenting out so
we do not end up running it regularly since it would wait us to login.
… as well

Apparently that test was "always" skipped, so we will just do the same
on github actions for now
@yarikoptic yarikoptic marked this pull request as ready for review May 1, 2024 00:11
@yarikoptic
Copy link
Member

ok, green now (after we just started to skip here too ;) ) -- so let's merge and consider "DONE" ;)

@yarikoptic yarikoptic merged commit ce67447 into master May 1, 2024
9 checks passed
@jwodder jwodder deleted the gh-98 branch July 12, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from travis to github actions
2 participants