Fix/remove outdated fields #914
Conversation
task/script.js
Outdated
| @@ -192,28 +216,32 @@ taskForm.onsubmit = async (e) => { | |||
| delete dataToBeSent.endsOn; | |||
| } | |||
|
|
|||
| if (status === 'AVIALABLE') { | |||
| if (status === 'AVAILABLE') { | |||
There was a problem hiding this comment.
Don’t we have any enum available here
There was a problem hiding this comment.
Nope, I couldn't find any
There was a problem hiding this comment.
Then please create it and use it
There was a problem hiding this comment.
Then please create it and use it
Did it, please do review
| @@ -0,0 +1,106 @@ | |||
| const API_BASE_URL = 'https://api.realdevsquad.com'; | |||
There was a problem hiding this comment.
I think we already have defined the based URL in the test config can you please check
There was a problem hiding this comment.
I have checked, I couldnt find can you tell me which file?
Also if you check task-dependency.test.js also has const API_BASE_URL = 'https://api.realdevsquad.com'; let me know if it can be replaced
There was a problem hiding this comment.
Use data test id instead of classes and id
There was a problem hiding this comment.
I can but this code has later to be removed anyways, why should we update index.html and add data test id's, id's and classes seems fine, isn't it?
sunilk429
force-pushed
the
fix/remove-outdated-fields
branch
from
f7c9163 to
e67974b
Compare
sunilk429
force-pushed
the
fix/remove-outdated-fields
branch
from
83db091 to
14374bd
Compare
Date: 17th November, 2024
Developer Name: Sunil Kumar
Issue Ticket Number
Description
The following fields needs to be removed according to new requirements
featureUrlfeature/groupradio buttonTask level section
categorylevelDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1