Dev to Main Sync #923
Merged
Dev to Main Sync #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#922) * removed feature flag * feat: loader on deleting groups * test: added test for loader
* featureUrl removed * removed feature/group * change class inputBox instead radioButton * task level section removed * unncessary object destruction under featureflag removed * status=available typo fixed * tests added for updated changes * Tests fixed * Added data-testid for testing,also added new tests * Test api updated to staging * refactored for readability * created a constants file * API_BASE_URL changed to stating for testing
Deploying dashboard-rds with
|
| Latest commit: |
1ecffc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7cc300a5.dashboard-rds.pages.dev |
| Branch Preview URL: | https://develop.dashboard-rds.pages.dev |
added code css property
Date: 17th December, 2024Developer Name: Sunil KumarIssue Ticket NumberPR's to Sync
|
* Added input validation and toast based on api response - behind dev flag. * Added tests for input validation and edit button under dev flag. * Added dev flag in ER update api request. * Resolved failing test cases. * Updated failing tests based on new changes. * Added missing tests. * Changed the confusing dev feature flag name. * Added Error Handling for Unavailable user details. * Changes style values to 8/4 metric and made toast timing a constant. * Changed the getSelfUser endpoint to new one. * Updated the getSelfUser() url for tests. * Fix: Prevent Code Format Overflow in Task Request Page (#927) added code css property * Added input validation and toast based on api response - behind dev flag. * Took latest pull from develop and merged it. * Added missing tests. * Changes style values to 8/4 metric and made toast timing a constant. * Made shouldDisplayEditButton() a pure function. * Added tests for input validation and edit button under dev flag. * Updated failing tests based on new changes. * Added missing tests. * Made shouldDisplayEditButton() a pure function. * Rebased and removed duplicate tests. --------- Co-authored-by: Rishi <[email protected]> Co-authored-by: Anuj Chhikara <[email protected]>
Date: 19th December, 2024Developer Name: Tanu ChahalIssue Ticket NumberPR's to SyncTask-1-Staging-Pr-Test.mp4 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 04 Dec 2024
Developer Name: @VaibhavSingh8 @tanu-chahal @sunilk429 @AnujChhikara
Issue Ticket Number
PR's to Sync
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
staging-test.mov