Allow user to edit Extension Requests before approval

[ahsrah7]

Date: 17-10-2024

Developer Name: Harshavardhan

---

Issue Ticket Number

• closes Allow Users to Edit Extension Requests Before Approval #2195

Description

• Allows user to edit an extension request if it is not yet approved.

Documentation Updated?

• Yes
• No

Under Feature Flag

• Yes
• No

Database Changes

• Yes
• No

Breaking Changes

• Yes
• No

Development Tested?

• Yes
• No

Screenshots

Screenshot 1

edit_er_before_approved.mp4

Test Coverage

Screenshot 1

Additional Notes

The skipAuthorizeRolesUnderFF & authorizeRoles middleware added to enable editing of Extension Request by normal user besides the other privileged users. The same is mention in the below issue created.

• Remove middlewares when removing the feature flag from Extention Requests #2265

[pankajjs]

1. There are no tests for disabled feature flag.
2. Could you add the test coverage for you changes?

[ahsrah7]

1. There are no tests for disabled feature flag.
2. Could you add the test coverage for you changes?

• will the tests for the feature flag not become the tests once feature flag is removed?
• I have added the relevant test cases but if you have any specific cases please mention

[pankajjs]

1. There are no tests for disabled feature flag.
2. Could you add the test coverage for you changes?

• will the tests for the feature flag not become the tests once feature flag is removed?
• I have added the relevant test cases but if you have any specific cases please mention

@ahsrah7 I don't see any test when dev=false.

[ahsrah7]

1. There are no tests for disabled feature flag.
2. Could you add the test coverage for you changes?

• will the tests for the feature flag not become the tests once feature flag is removed?
• I have added the relevant test cases but if you have any specific cases please mention

@ahsrah7 I don't see any test when dev=false.

@pankajjs please let me know if I am getting this correctly. The existing flow where only super user can edit the ERs already has test cases. For the changes I have added where a normal user can also edit the ER until it is approved is under FF so have added tests accordingly. For the case which you are mentioning dev=false should be the test cases for the already existing flow which are already present. If I am missing anything please let me know.

[pankajjs]

As I see in updateExtensionRequest, you have introduced dev flag. When dev is false, you are returning res.boom.badRequest("Extension Request cannot be updated") this. But you have not written test for this.

[ahsrah7]

As I see in updateExtensionRequest, you have introduced dev flag. When dev is false, you are returning res.boom.badRequest("Extension Request cannot be updated") this. But you have not written test for this.

Yes I have introduced the dev flag but when dev flag is false the control does not reach the updateExtensionRequest at all. But thanks for raising this I notice that string type dev flag is always being type casted to true irrespective of the value provided in the query params.