Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main Sync #2270

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Dev to Main Sync #2270

merged 1 commit into from
Nov 27, 2024

Conversation

Achintya-Chatterjee
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee commented Nov 26, 2024

Date: 28th November, 2024

Developer Name: @ahsrah7


Issue Ticket Number

PR's going in this sync

Description

Once a user raises an extension request, they cannot edit it, regardless of its status. This issue creates problems when users need to update or correct information before approval. this PR solved this issue

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
staging_ER_normaluser.mp4

Test Coverage

Screenshot 1 Screenshot 2024-11-28 at 00 35 31

Additional Notes

* added edit ability  for ER

* fixing function name and export type

* fix feature flag value check

* error message and status code updated

* middleware tests added

* pending status check added

* added comment regarding middleware for FF removal
@Real-Dev-Squad Real-Dev-Squad deleted a comment from ahsrah7 Nov 27, 2024
@iamitprakash iamitprakash merged commit 12f3acc into main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants