Navbar link's scroll position resolved. #194
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,6 +111,10 @@ export default function Event() { | |
| }; | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); | ||
|
|
||
| return ( | ||
| <> | ||
| <div id="event" className="w-full h-fit bg-amber-100 md:overflow-hidden "> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,19 @@ | ||
|
|
||
| import Landing from "../ui/Landing"; | ||
| import ReviewCarousel from "../ui/ReviewCarousel"; | ||
| import FeedbackForm from "../ui/FeedbackForm"; | ||
| import About from "./About"; | ||
| import React, { useEffect } from 'react'; | ||
|
|
||
| export default function Home() { | ||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); | ||
| return ( | ||
| <div id="home" className="bg-[#FDF3C7]"> | ||
| <Landing /> | ||
| <About/> | ||
| <ReviewCarousel/> | ||
| <FeedbackForm /> | ||
| </div> | ||
| ) | ||
Ashwinib26 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,12 @@ | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| import React, { useState , useEffect } from "react"; | ||||||||||||||||||||||||||
| import { Link } from "react-router-dom"; | ||||||||||||||||||||||||||
| import photo from "../../assets/login.png"; | ||||||||||||||||||||||||||
|
There was a problem hiding this comment. @Ashwinib26 you add twice it remove and follow code rabit suggestions |
||||||||||||||||||||||||||
| import { Link, useNavigate } from "react-router-dom"; | ||||||||||||||||||||||||||
| import photo from "../../assets/login.png"; | ||||||||||||||||||||||||||
| import React, { useState } from "react"; | ||||||||||||||||||||||||||
| import { message } from "antd"; | ||||||||||||||||||||||||||
|
Comment on lines
+1
to
+8
There was a problem hiding this comment. Consolidate duplicate imports There are several duplicate import statements that need to be addressed. This can lead to confusion and potential issues in the future. Please apply the following changes to clean up the imports: -import React, { useState , useEffect } from "react";
-import { Link } from "react-router-dom";
-import photo from "../../assets/login.png";
-import { Link, useNavigate } from "react-router-dom";
-import photo from "../../assets/login.png";
-import React, { useState } from "react";
+import React, { useState, useEffect } from "react";
+import { Link, useNavigate } from "react-router-dom";
+import photo from "../../assets/login.png";
import { message } from "antd";This will remove the duplicate imports and consolidate them into a clean, organized import section. 📝 Committable suggestion
Suggested change
🧰 Tools🪛 Biome
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| const Login = () => { | ||||||||||||||||||||||||||
| const API_URL = import.meta.env.VITE_BACKEND_URL || 'http://localhost:3000'; | ||||||||||||||||||||||||||
|
|
@@ -43,6 +48,10 @@ const Login = () => { | |||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| useEffect(() => { | ||||||||||||||||||||||||||
| window.scrollTo(0, 0); | ||||||||||||||||||||||||||
| }, []); | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||
| <div className="w-screen h-screen flex items-center justify-center pt-10"> | ||||||||||||||||||||||||||
| <img src={photo} alt="login" className=" w-3/4 absolute" /> | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
|
|
||
| import { useState , useEffect } from 'react'; | ||
|
|
||
| import { motion } from 'framer-motion'; | ||
| import Mybook from './MyBook'; | ||
| import TodaysSpecial from './TodaysSpecial'; | ||
|
|
@@ -28,6 +30,10 @@ function ParallaxImage() { | |
| y: mousePosition.y / 30, | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); | ||
|
|
||
| return ( | ||
| <> | ||
| <div | ||
|
|
@@ -61,10 +67,16 @@ function ParallaxImage() { | |
| <h1 className="text-5xl md:text-9xl font-roboto">Flip Menu</h1> | ||
| <GiArrowDunk size={60} className="mt-2 text-orange-400" /> | ||
| </div> | ||
| {/* <div className="w-full md:flex md:items-center md:justify-center"> | ||
| <Mybook /> | ||
| </div> | ||
| <TodaysSpecial /> */} | ||
| <div className="w-full md:flex md:items-center md:justify-center mb-20"> {/* Adjust this container */} | ||
| <Mybook /> | ||
| </div> | ||
| <div className="w-full md:flex md:items-center md:justify-center" style={{ paddingBottom: '80px' }}> {/* Add bottom padding here */} | ||
| <TodaysSpecial /> | ||
| </div> | ||
| </div> | ||
| </> | ||
| ); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,10 @@ function MyBook() { | |
| return () => window.removeEventListener('resize', handleResize); | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); | ||
|
|
||
| return ( | ||
| <div | ||
| style={BgTextureStyle} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,25 @@ | ||
|
|
||
| import Notfound from "../../assets/Menu_assets/Notfound.gif" | ||
| import React, { useState , useEffect } from 'react'; | ||
|
|
||
| const NotFound = () => { | ||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); | ||
| return ( | ||
| <div> | ||
| <div className="flex flex-col items-center justify-center h-screen"> | ||
| <h1 className="text-5xl font-bold mb-8 text-center">404 Not Found</h1> | ||
| <img | ||
| src={Notfound} // Replace with your actual GIF path | ||
| alt="Not Found GIF" | ||
| className="w-full max-w-md" | ||
| /> | ||
| <p className="mt-8 text-lg text-gray-700 text-center"> | ||
| Sorry, the page you are looking for could not be found. | ||
| </p> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
| export default NotFound; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,12 @@ | ||
|
|
||
| import PropTypes from "prop-types"; | ||
| import React, { useState , useEffect , forwardRef } from 'react'; | ||
|
|
||
|
|
||
| const Page = forwardRef((props, ref) => { | ||
| useEffect(() => { | ||
| window.scrollTo(0, 0); | ||
| }, []); | ||
| return ( | ||
| <div className="demoPage bg-white" ref={ref}> | ||
| <div className="h-full">{props.children}</div> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate
handleCloseInstructionsfunctionThe
handleCloseInstructionsfunction is defined here and again later in the code (after line 192). Having duplicate definitions can lead to unexpected behavior or confusion.Please remove one of the definitions to avoid duplication. Here's how you can remove this instance:
📝 Committable suggestion