Add call stack management #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyas-streamhpc
changed the base branch from
hip_runtime_api_how-to
to
docs/develop
matyas-streamhpc
force-pushed
the
call-stack
branch
from
a506459
to
26c2cc4
Compare
matyas-streamhpc
changed the base branch from
docs/develop
to
hip_runtime_api_how-to
neon60
force-pushed
the
hip_runtime_api_how-to
branch
from
38d2787
to
8d5b771
Compare
neon60
force-pushed
the
call-stack
branch
5 times, most recently
from
6ebbb51
to
ed54ad1
Compare
neon60
requested review from
chrispaquot,
gandryey,
saleelk,
mangupta and
rakesroy
as code owners
MKKnorr
reviewed
Oct 31, 2024
There was a problem hiding this comment.
This could also additionally benefit from a section explaining, that the higher memory requirement of the GPUs call stack is why the call stack per thread is small compared to that of a CPU, and that this is the reason why (deep) recursion is not recommended, even if it's possible.
It would also be good to mention, that most device function calls are inlined to prevent excessive stack growth (and maybe for performance reasons)
neon60
force-pushed
the
hip_runtime_api_how-to
branch
from
8d5b771
to
96cf3a6
Compare
matyas-streamhpc
force-pushed
the
call-stack
branch
2 times, most recently
from
8c5264e
to
73894e3
Compare
MKKnorr
reviewed
Nov 6, 2024
matyas-streamhpc
force-pushed
the
call-stack
branch
2 times, most recently
from
8dcbdcc
to
507ebf1
Compare
neon60
force-pushed
the
hip_runtime_api_how-to
branch
2 times, most recently
from
eb41cb1
to
7cb026c
Compare
MKKnorr
approved these changes
Nov 8, 2024
randyh62
approved these changes
Nov 9, 2024
randyh62
approved these changes
Nov 12, 2024
MKKnorr
reviewed
Nov 14, 2024
neon60
force-pushed
the
hip_runtime_api_how-to
branch
from
0c52420
to
31fa125
Compare
neon60
force-pushed
the
call-stack
branch
4 times, most recently
from
bc51f5b
to
0fa1614
Compare
MKKnorr
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.