Simplify GitHub Action (fork PR) #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
cbjuan,
d-kremer,
victor-villar,
jesus-talavera-ibm and
y4izus
as code owners
|
Hm, the tests won't work because I'm running CI from a fork. Options:
|
|
Thank you @Eric-Arellano !! I will give you Write access these days. I think is the better option right now :) |
|
Sg. I'll recreate this from a new branch once I have write access. |
Merged
Eric-Arellano
added a commit
that referenced
this pull request
Aug 8, 2024
Built on top of #32. Makes better use of GitHub Action's sensible defaults: * No need to enumerate every type of `pull_request` event. The default already does what you want: running every time you make a change to the PR * No need to set arguments to `actions/checkout` - `fetch_depth: 0` results in fetching every single commit, which gets slow as the repository grows. You probably only need the latest commit to run linters and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes better use of GitHub Action's sensible defaults:
pull_requestevent. The default already does what you want: running every time you make a change to the PRactions/checkoutfetch_depth: 0results in fetching every single commit, which gets slow as the repository grows. You probably only need the latest commit to run linters and tests