Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GitHub Action #33

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Simplify GitHub Action #33

merged 1 commit into from
Aug 8, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Built on top of #32.

Makes better use of GitHub Action's sensible defaults:

  • No need to enumerate every type of pull_request event. The default already does what you want: running every time you make a change to the PR
  • No need to set arguments to actions/checkout
    • fetch_depth: 0 results in fetching every single commit, which gets slow as the repository grows. You probably only need the latest commit to run linters and tests

Copy link
Collaborator

@y4izus y4izus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@Eric-Arellano Eric-Arellano merged commit 603bd86 into main Aug 8, 2024
5 of 7 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/simplify-gh-action branch August 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants