Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial qiskit-neko CI job #1422

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Add initial qiskit-neko CI job #1422

merged 6 commits into from
Oct 21, 2024

Conversation

mtreinish
Copy link
Member

Summary

In Qiskit/qiskit-neko#41 we're updating the default simulator backend plugin used by qiskit-neko to rely on the fake backends provider in the qiskit-ibm-runtime project. A key aspect of qiskit-neko is the reciprocity of testing to maintain compatibility in the qiskit ecosystem (see:
https://github.com/Qiskit/qiskit-neko?tab=readme-ov-file#downstream-usage-in-testing) so to ensure this is maintainable and the interface remains compatible for every project using neko this commit adds a corresponding job to exercise the qiskit-ibm-runtime usage in the tests. However, this is blocked until after Qiskit/qiskit-neko#41 merges as that is needed to fix the test suite. A followup will be needed to add a backend selection to the action configuration so that we can actually use a fake backend.

A longer term step we should investigate is adding a qiskit-neko plugin to the repo which would enable using qiskit-ibm-runtime's backends and primitives directly for integration testing with real backends. But that is much longer term and isn't part of this commit.

Details and comments

In Qiskit/qiskit-neko#41 we're updating the default simulator backend
plugin used by qiskit-neko to rely on the fake backends provider in the
qiskit-ibm-runtime project. A key aspect of qiskit-neko is the
reciprocity of testing to maintain compatibility in the qiskit
ecosystem (see:
https://github.com/Qiskit/qiskit-neko?tab=readme-ov-file#downstream-usage-in-testing)
so to ensure this is maintainable and the interface remains compatible
for every project using neko this commit adds a corresponding job to
exercise the qiskit-ibm-runtime usage in the tests. However, this is
blocked until after Qiskit/qiskit-neko#41 merges as that is needed to
fix the test suite. A followup will be needed to add a backend selection
to the action configuration so that we can actually use a fake backend.

A longer term step we should investigate is adding a qiskit-neko plugin
to the repo which would enable using qiskit-ibm-runtime's backends and
primitives directly for integration testing with real backends. But that
is much longer term and isn't part of this
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8019661440

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.972%

Totals Coverage Status
Change from base Build 7980192356: 0.0%
Covered Lines: 5034
Relevant Lines: 6217

💛 - Coveralls

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current neko failure is dues to an incompatibility in qiskit_algorithms with scipy>=1.14, the bug was fixed in main (qiskit-community/qiskit-algorithms@3fb69b3), but neko is pulling the latest released version which doesn't include the fix. I can do a patch release of algorithms, but given the current level of maintenance of the repo, it might make sense considering installing the package from source when running neko.

@ElePT ElePT merged commit c689b98 into Qiskit:main Oct 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants