-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SkillCorner extrapolated_data.jsonl loading functionality #215
Conversation
Thanks for the work @UnravelSports, I'm also interested in the .jsonl loading functionality for SkillCorner data! @JanVanHaaren @koenvo what are your thoughts on the last point raised regarding the start timestamp of the second period? |
With open removed
@koenvo @UnravelSports this commit should still be applied prior to merging imo. This way we use the SkillCorner ID as the player ID in the dataset. I'd love to do it myself but I can't contribute to this PR. So can any of you guys apply the changes? @koenvo do you know why some of the checks are failing? |
I've added a minor change as requested by @DriesDeprest which is a simple rewrite of what player ids we use in the SkillCorner parser. See his personal fork 277a714 |
@UnravelSports Could you please merge the |
It seems I've made a mess out of this, I'm creating a new PR to make a clean PR 😆 |
I noticed there was no support for loading
extrapolated_data.jsonl
files, only deprecatedstructured_data.json
files.As you can see in the messy commit history I've added a couple things:
jsonl
files if that file suffix is in place forraw_data
. This functionality simply converts the json lines to a list of json objects such that it looks exactly like thestructured_data.json
files. We also rename thetimestamp
key totime
to make it compatible with the rest of the code (that relies on the oldtime
key).extrapolated
files have a slightly different timestamp format. The old format is"92:37.60"
whereas the new format would display this as"01:32:37.60"
. The_timestamp_from_timestring()
function can now handle both cases, converting both of these formats to the same output.Finally, I would not be surprised if the tests fail because of the change in period start time...