Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo of #PR215 #278

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Redo of #PR215 #278

merged 2 commits into from
Jan 22, 2024

Conversation

UnravelSports
Copy link
Contributor

@UnravelSports UnravelSports commented Jan 11, 2024

Because I made a mess of PR #215, here is a clean attempt.
It includes updated jsonl loader without with open(), Dries' minor changes to IDs as proposed in 277a714 and updated event_factory.

…es' minor change to IDs and updated event_factory
@JanVanHaaren
Copy link
Collaborator

Thanks, @UnravelSports! The changes to the SkillCorner deserializer look good to me.

Could you please fix the code formatting? I suspect that the formatting changes to the event data deserializers were unintentional.

@JanVanHaaren
Copy link
Collaborator

@UnravelSports I've managed to make the necessary changes myself. 😊

@UnravelSports
Copy link
Contributor Author

@JanVanHaaren for future reference, what formatting was wrong? Because I did run black on all the files, so kinda curious where it went wrong

Thanks for fixing it and approving of the changes!

@JanVanHaaren
Copy link
Collaborator

@JanVanHaaren for future reference, what formatting was wrong? Because I did run black on all the files, so kinda curious where it went wrong

Good question. I suspect that you're using a different version of black that has slightly different default preferences, but I'm not entirely sure.

@UnravelSports
Copy link
Contributor Author

Good point, I'll update :)

@koenvo koenvo added this to the 3.15 milestone Jan 22, 2024
@koenvo koenvo merged commit 3360c6e into PySport:master Jan 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants