Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): allow triggering session recording based on urls #25451

Merged
merged 37 commits into from
Oct 17, 2024
Merged

feat(replay): allow triggering session recording based on urls #25451

merged 37 commits into from
Oct 17, 2024

Conversation

richard-better
Copy link
Contributor

@richard-better richard-better commented Oct 8, 2024 •
edited
Loading

Problem

Part of #25340

Backend and admin bits for PostHog/posthog-js#1451

Changes

Screenshot 2024-10-17 at 11 19 59 Screenshot 2024-10-17 at 11 20 08 Screenshot 2024-10-17 at 11 20 24

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@richard-better richard-better changed the title add new property for url triggers feat: allow triggering session replay based on urls Oct 8, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Size Change: +56 B (0%)

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.14 MB +56 B (0%)

compressed-size-action

Richard Borcsik added 4 commits October 14, 2024 09:54
pauldambra
pauldambra reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the migration needs updating to be latest

left a few thoughts but this could go in as it is once the migration is up to date

frontend/src/scenes/teamActivityDescriber.tsx Show resolved Hide resolved
posthog/migrations/0488_team_session_recording_url_trigger_config.py Outdated Show resolved Hide resolved
frontend/__snapshots__/scenes-other-settings--settings-project-with-replay-features--dark.png Outdated Show resolved Hide resolved
frontend/src/scenes/settings/environment/SessionRecordingSettings.tsx Show resolved Hide resolved
frontend/src/scenes/settings/environment/SessionRecordingSettings.tsx Show resolved Hide resolved
frontend/__snapshots__/scenes-other-settings--settings-project-with-replay-features--light.png Outdated Show resolved Hide resolved
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@richard-better richard-better marked this pull request as ready for review October 17, 2024 09:36
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Twixes and others added 5 commits October 17, 2024 12:43
@Twixes
Update _update_team
1def1cb
Merge branch 'master' into richard/url-trigger
05b9423 
# Conflicts:
#	frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--light.png
#	latest_migrations.manifest
update migrations
b99c70d
@github-actions
Update query snapshots
2731c8b
@github-actions
Update UI snapshots for chromium (1)
5428649
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

pauldambra
pauldambra approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think the settings sections are getting messy now but no reason to block testing this with UI fangling 👍

@richard-better richard-better changed the title feat: allow triggering session replay based on urls feat(replay): allow triggering session replay based on urls Oct 17, 2024
@richard-better richard-better changed the title feat(replay): allow triggering session replay based on urls feat(replay): allow triggering session recording based on urls Oct 17, 2024
@richard-better richard-better merged commit 6a937b3 into master Oct 17, 2024
98 checks passed
@richard-better richard-better deleted the richard/url-trigger branch October 17, 2024 12:58
timgl pushed a commit that referenced this pull request Oct 17, 2024
@richard-better @github-actions
@Twixes @timgl
feat(replay): allow triggering session recording based on urls (#25451)
f5e0af4 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Matloka <[email protected]>
@stuartbrameld
Copy link

this is brilliant! 🍾

@pauldambra
Copy link
Member

awesome news, thanks @stuartbrameld

@stuartbrameld
Copy link

@pauldambra just to provide some additional context here - I think the incremental scaling of pricing is one of the most compelling things about PostHog as product but it didn't exist with session recording (until now) .... it was basically either on or off. This is one of those things where a lot of marketing teams had been using MS Clarity/HotJar before, for free. Telling a team they need to go from $0/month spend to $200+/month for a product is a tough sell, but being able to expand session recording coverage over time and go from $0 to $50 (homepage), to $100 (product pages), to $200 (blog area) is much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richard-better @posthog-bot @stuartbrameld @pauldambra @Twixes