-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(replay): allow triggering session recording based on urls (#25451)
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Matloka <[email protected]>
- Loading branch information
Showing
30 changed files
with
971 additions
and
284 deletions.
There are no files selected for viewing
Binary file modified
BIN
-13 Bytes
(100%)
...pshots__/scenes-other-settings--settings-project-with-replay-features--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-38 Bytes
(100%)
...shots__/scenes-other-settings--settings-project-with-replay-features--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
158 changes: 158 additions & 0 deletions
158
frontend/src/scenes/settings/environment/sessionReplayIngestionControlLogic.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| import { actions, afterMount, connect, kea, listeners, path, props, reducers, selectors, sharedListeners } from 'kea' | ||
| import { forms } from 'kea-forms' | ||
| import { loaders } from 'kea-loaders' | ||
| import { subscriptions } from 'kea-subscriptions' | ||
| import api from 'lib/api' | ||
| import { isObject } from 'lib/utils' | ||
| import { variantKeyToIndexFeatureFlagPayloads } from 'scenes/feature-flags/featureFlagLogic' | ||
| import { teamLogic } from 'scenes/teamLogic' | ||
|
|
||
| import { FeatureFlagBasicType, SessionReplayUrlTriggerConfig, TeamPublicType, TeamType } from '~/types' | ||
|
|
||
| import type { sessionReplayIngestionControlLogicType } from './sessionReplayIngestionControlLogicType' | ||
|
|
||
| const NEW_URL_TRIGGER = { url: '', matching: 'regex' } | ||
|
|
||
| export const sessionReplayIngestionControlLogic = kea<sessionReplayIngestionControlLogicType>([ | ||
| path(['scenes', 'settings', 'project', 'sessionReplayIngestionControlLogic']), | ||
| actions({ | ||
| selectFeatureFlag: (flag: FeatureFlagBasicType) => ({ flag }), | ||
| setUrlTriggerConfig: (urlTriggerConfig: SessionReplayUrlTriggerConfig[]) => ({ urlTriggerConfig }), | ||
|
|
||
| addUrlTrigger: (urlTriggerConfig: SessionReplayUrlTriggerConfig) => ({ urlTriggerConfig }), | ||
| removeUrlTrigger: (index: number) => ({ index }), | ||
| updateUrlTrigger: (index: number, urlTriggerConfig: SessionReplayUrlTriggerConfig) => ({ | ||
| index, | ||
| urlTriggerConfig, | ||
| }), | ||
| setEditUrlTriggerIndex: (originalIndex: number | null) => ({ originalIndex }), | ||
| newUrlTrigger: true, | ||
| cancelProposingUrlTrigger: true, | ||
| }), | ||
| connect({ values: [teamLogic, ['currentTeam']], actions: [teamLogic, ['updateCurrentTeam']] }), | ||
| reducers({ | ||
| selectedFlag: [ | ||
| null as FeatureFlagBasicType | null, | ||
| { | ||
| selectFeatureFlag: (_, { flag }) => flag, | ||
| }, | ||
| ], | ||
| urlTriggerConfig: [ | ||
| null as SessionReplayUrlTriggerConfig[] | null, | ||
| { | ||
| setUrlTriggerConfig: (_, { urlTriggerConfig }) => urlTriggerConfig, | ||
| addUrlTrigger: (state, { urlTriggerConfig }) => [...(state ?? []), urlTriggerConfig], | ||
| updateUrlTrigger: (state, { index, urlTriggerConfig: newUrlTriggerConfig }) => | ||
| (state ?? []).map((triggerConfig, i) => (i === index ? newUrlTriggerConfig : triggerConfig)), | ||
| removeUrlTrigger: (state, { index }) => { | ||
| return (state ?? []).filter((_, i) => i !== index) | ||
| }, | ||
| }, | ||
| ], | ||
| editUrlTriggerIndex: [ | ||
| null as number | null, | ||
| { | ||
| setEditUrlTriggerIndex: (_, { originalIndex }) => originalIndex, | ||
| removeUrlTrigger: (editUrlTriggerIndex, { index }) => | ||
| editUrlTriggerIndex && index < editUrlTriggerIndex | ||
| ? editUrlTriggerIndex - 1 | ||
| : index === editUrlTriggerIndex | ||
| ? null | ||
| : editUrlTriggerIndex, | ||
| newUrlTrigger: () => -1, | ||
| updateUrlTrigger: () => null, | ||
| addUrlTrigger: () => null, | ||
| cancelProposingUrlTrigger: () => null, | ||
| }, | ||
| ], | ||
| }), | ||
| props({}), | ||
| loaders(({ values }) => ({ | ||
| featureFlag: { | ||
| loadFeatureFlag: async () => { | ||
| if (values.linkedFeatureFlagId) { | ||
| const retrievedFlag = await api.featureFlags.get(values.linkedFeatureFlagId) | ||
| return variantKeyToIndexFeatureFlagPayloads(retrievedFlag) | ||
| } | ||
| return null | ||
| }, | ||
| }, | ||
| })), | ||
| selectors({ | ||
| linkedFeatureFlagId: [ | ||
| (s) => [s.currentTeam], | ||
| (currentTeam) => currentTeam?.session_recording_linked_flag?.id || null, | ||
| ], | ||
| linkedFlag: [ | ||
| (s) => [s.featureFlag, s.selectedFlag, s.currentTeam], | ||
| // an existing linked flag is loaded from the API, | ||
| // a newly chosen flag is selected can be passed in | ||
| // the current team is used to ensure that we don't show stale values | ||
| // as people change the selection | ||
| (featureFlag, selectedFlag, currentTeam) => | ||
| currentTeam?.session_recording_linked_flag?.id ? selectedFlag || featureFlag : null, | ||
| ], | ||
| flagHasVariants: [(s) => [s.linkedFlag], (linkedFlag) => isObject(linkedFlag?.filters.multivariate)], | ||
| remoteUrlTriggerConfig: [ | ||
| (s) => [s.currentTeam], | ||
| (currentTeam) => currentTeam?.session_recording_url_trigger_config, | ||
| ], | ||
| isAddUrlTriggerConfigFormVisible: [ | ||
| (s) => [s.editUrlTriggerIndex], | ||
| (editUrlTriggerIndex) => editUrlTriggerIndex === -1, | ||
| ], | ||
| urlTriggerToEdit: [ | ||
| (s) => [s.urlTriggerConfig, s.editUrlTriggerIndex], | ||
| (urlTriggerConfig, editUrlTriggerIndex) => { | ||
| if ( | ||
| editUrlTriggerIndex === null || | ||
| editUrlTriggerIndex === -1 || | ||
| !urlTriggerConfig?.[editUrlTriggerIndex] | ||
| ) { | ||
| return NEW_URL_TRIGGER | ||
| } | ||
| return urlTriggerConfig[editUrlTriggerIndex] | ||
| }, | ||
| ], | ||
| }), | ||
| afterMount(({ actions }) => { | ||
| actions.loadFeatureFlag() | ||
| }), | ||
| subscriptions(({ actions }) => ({ | ||
| currentTeam: (currentTeam: TeamPublicType | TeamType | null) => { | ||
| actions.setUrlTriggerConfig(currentTeam?.session_recording_url_trigger_config ?? []) | ||
| }, | ||
| })), | ||
| forms(({ values, actions }) => ({ | ||
| proposedUrlTrigger: { | ||
| defaults: { url: '', matching: 'regex' } as SessionReplayUrlTriggerConfig, | ||
| submit: async ({ url, matching }) => { | ||
| if (values.editUrlTriggerIndex !== null && values.editUrlTriggerIndex >= 0) { | ||
| actions.updateUrlTrigger(values.editUrlTriggerIndex, { url, matching }) | ||
| } else { | ||
| actions.addUrlTrigger({ url, matching }) | ||
| } | ||
| }, | ||
| }, | ||
| })), | ||
| sharedListeners(({ values }) => ({ | ||
| saveUrlTriggers: async () => { | ||
| await teamLogic.asyncActions.updateCurrentTeam({ | ||
| session_recording_url_trigger_config: values.urlTriggerConfig ?? [], | ||
| }) | ||
| }, | ||
| })), | ||
| listeners(({ sharedListeners, actions, values }) => ({ | ||
| setEditUrlTriggerIndex: () => { | ||
| actions.setProposedUrlTriggerValue('url', values.urlTriggerToEdit.url) | ||
| actions.setProposedUrlTriggerValue('matching', values.urlTriggerToEdit.matching) | ||
| }, | ||
| addUrlTrigger: sharedListeners.saveUrlTriggers, | ||
| removeUrlTrigger: sharedListeners.saveUrlTriggers, | ||
| updateUrlTrigger: sharedListeners.saveUrlTriggers, | ||
| submitProposedUrlTriggerSuccess: () => { | ||
| actions.setEditUrlTriggerIndex(null) | ||
| actions.resetProposedUrlTrigger() | ||
| }, | ||
| })), | ||
| ]) |
Oops, something went wrong.