Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding portuguese strings.xml #131

Merged
merged 2 commits into from
May 11, 2024
Merged

Adding portuguese strings.xml #131

merged 2 commits into from
May 11, 2024

Conversation

theolm
Copy link
Contributor

@theolm theolm commented May 11, 2024

This PR adds Brazilian Portuguese strings to the app.

ps. I noticed some hardcoded strings in the app.

starry-shivam
starry-shivam requested changes May 11, 2024
View reviewed changes
Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you point out which strings you're referring to as hardcoded?

app/src/main/res/values-pt/strings.xml Outdated Show resolved Hide resolved
@theolm theolm requested a review from starry-shivam May 11, 2024 18:59
starry-shivam
starry-shivam approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@starry-shivam starry-shivam merged commit 6951009 into Pool-Of-Tears:main May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starry-shivam starry-shivam starry-shivam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theolm @starry-shivam