Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinationMarker Detector #482

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

jw098
Copy link
Collaborator

@jw098 jw098 commented Sep 13, 2024

To be used by overworld_navigation() in AutoStory.

@jw098 jw098 mentioned this pull request Sep 13, 2024



class DestinationMarkerWatcher : public VisualInferenceCallback{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detector is reliable enough that we don't need to use the consecutive frames timer right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had issues with false positives from my testing, and the template is moderately unique.
But I think holding detection for a few more frames is a good idea anyway. I'll update the PR.

@jw098 jw098 mentioned this pull request Sep 13, 2024
@Mysticial Mysticial merged commit ded8b3a into PokemonAutomation:main Sep 14, 2024
6 checks passed
@jw098 jw098 deleted the destinationdetector branch September 30, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants