Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autostory #466

Closed
wants to merge 71 commits into from
Closed

Autostory #466

wants to merge 71 commits into from

Conversation

jw098
Copy link
Collaborator

@jw098 jw098 commented Aug 25, 2024

This is quite a large PR. Let me know if you want it broken up.
I updated/added a few detectors/readers

  • WipeoutDetector
  • WhiteButtonDetector for both L Stick and A button with dark background
  • MenuOptionReader along with a menu option session for changing the settings
  • PokemonMovesReader
  • TutorialDetector

Credits to Nymphea for the majority of the autostory code.

@jw098
Copy link
Collaborator Author

jw098 commented Aug 29, 2024

I added a few commits to refactor test_segments, to use std::vector<std::function<void()>> instead of a large switch statement.

@Mysticial
Copy link
Collaborator

Without having looked into this in detail yet, let's break out all the detectors into separate PRs if they're able to stand alone.

@jw098
Copy link
Collaborator Author

jw098 commented Sep 13, 2024

I'll submit AutoStoryTools as its own PR once #482 and #483 are merged, since it depends on those.

@jw098 jw098 closed this Nov 14, 2024
@jw098 jw098 deleted the autostory branch November 17, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants