Replace os.stat sentinel file check with XRootD http GET #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
requested changes
Dec 5, 2024
|
@jhiemstrawisc left one comment asking for clarification, otherwise implemented the suggested changes |
jhiemstrawisc
requested changes
Dec 5, 2024
server_utils/origin.go
Outdated
| @@ -750,18 +754,64 @@ from S3 service URL. In this configuration, objects can be accessed at /federati | |||
| return originExports, nil | |||
| } | |||
|
|
|||
| // Generate a minimally scoped auth token that allows the origin | |||
| // to query itself for its sentinel file | |||
| func generateSentinelCheckScitoken(resourceScope string) (string, error) { | |||
There was a problem hiding this comment.
One last minor nitpick -- this function technically generates a WLCG token, which isn't the same as a scitoken. How about "generateSentinelReadToken"?
|
The failing test here is unrelated to changes and suggests a runtime hiccup in GHA. Rather than re-run, I'll just merge (was passing before this simple function rename). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.