Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel file for S3 origin #1017

Closed
haoming29 opened this issue Apr 1, 2024 · 2 comments · Fixed by #1791
Closed

Sentinel file for S3 origin #1017

haoming29 opened this issue Apr 1, 2024 · 2 comments · Fixed by #1791
Assignees
Labels
good first issue Good for newcomers origin Issue relating to the origin component
Milestone

Comments

@haoming29
Copy link
Contributor

As noted in #1003, we won't implement sentinel file for S3 until the S3 configuration changes are in place. Once that's done, we should add sentinel option for S3 origins.

@haoming29 haoming29 added the origin Issue relating to the origin component label Apr 1, 2024
@haoming29 haoming29 modified the milestones: v7.7.0, v7.8.0 Apr 1, 2024
@bbockelm bbockelm modified the milestones: v7.8.0, v7.9.0 May 8, 2024
@jhiemstrawisc jhiemstrawisc modified the milestones: v7.9.0, v7.10.0 Jun 14, 2024
@jhiemstrawisc
Copy link
Member

It looks like fix for this should target this section of code. If we can make it compatible with S3, we should get http compatibility more or less for free.

@jhiemstrawisc
Copy link
Member

Closed by #1791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers origin Issue relating to the origin component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants