Correctly return the transfer attempt information #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v7.6.x has a regression where the `downloadObject` function returns an error whenever an error occurs; rather, it's only supposed to return an error if no transfers are attempted. That change causes the multiple attempts to not be returned to the transfer plugin -- instead, only the last one is. This change: - Returns all the failed attempts - Fixes the "15s since start" in error messages by recording when the error occurred. - Stubs out any paths in the plugin error message (since HTCSS also reports the path). - Switches the client to golang time objects where appropriate, converting to integers (and floats) only at the plugin level.
bbockelm
added
bug
Previously, errors were converted to a long string which loses the type information of the error. Parts of the local cache were depending on extracting the error stack, causing test failures.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v7.6.x has a regression where the
downloadObjectfunction returns an error whenever an error occurs; rather, it's only supposed to return an error if no transfers are attempted. That change causes the multiple attempts to not be returned to the transfer plugin -- instead, only the last one is.This change: