Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unit test coverage around multiple transfer attempts #1064

Open
bbockelm opened this issue Apr 6, 2024 · 0 comments
Open

Provide unit test coverage around multiple transfer attempts #1064

bbockelm opened this issue Apr 6, 2024 · 0 comments
Labels
client Issue affecting the OSDF client test Improvements to the test suite
Milestone

Comments

@bbockelm
Copy link
Collaborator

bbockelm commented Apr 6, 2024

In 7.6.x, we broke the ability to return multiple attempts in the plugin output. This is because we set the incorrect error object.

The fixes are in #1063 (but that came right up against the release day); this issue is for the regression test coverage.

We should check the following are done:

  1. Ensure that, on success, the number of attempts is non-zero.
  2. Force the transfer to take at least a second then ensure the total transfer time is >1s.
  3. Register two caches (both httptest servers, not actual "federation in a box" caches) for a test federation. Have the first download always fail and second succeed. Check attempts and the developer data in the plugin.
  4. Same as above but make both downloads fail. Check the attempts and error messages.
@bbockelm bbockelm added test Improvements to the test suite client Issue affecting the OSDF client labels Apr 6, 2024
@jhiemstrawisc jhiemstrawisc added this to the parking-lot milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issue affecting the OSDF client test Improvements to the test suite
Projects
None yet
Development

No branches or pull requests

3 participants