Fix filesystem radio type annotation: the wrong kind of Queue #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, filesystem_receiver was annotated as taking queue.Queue. This was incorrect (but not detected or enforced by any tooling - because type annotations are not carried across the invoking Process constructor) The receiver actually takes a multiprocessing.Queue, which is used without a namespace, like the rest of this source file.
khk-globus
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, filesystem_receiver was annotated as taking queue.Queue. This was incorrect (but not detected or enforced by any tooling - because type annotations are not carried across the invoking Process constructor)
The receiver actually takes a multiprocessing.Queue, which is used without a namespace, like the rest of this source file.
Type of change