Skip to content

Commit

Permalink
Fix filesystem radio type annotation: the wrong kind of Queue (#3691)
Browse files Browse the repository at this point in the history
Prior to this PR, filesystem_receiver was annotated as taking
queue.Queue. This was incorrect (but not detected or enforced by any
tooling - because type annotations are not carried across the invoking
Process constructor)

The receiver actually takes a multiprocessing.Queue, which is used
without a namespace, like the rest of this source file.

## Type of change

- Code maintenance/cleanup
  • Loading branch information
benclifford authored Nov 8, 2024
1 parent 3fa1599 commit 166cb03
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion parsl/monitoring/monitoring.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def close(self) -> None:


@wrap_with_logs
def filesystem_receiver(logdir: str, q: "queue.Queue[TaggedMonitoringMessage]", run_dir: str) -> None:
def filesystem_receiver(logdir: str, q: Queue[TaggedMonitoringMessage], run_dir: str) -> None:
logger = set_file_logger("{}/monitoring_filesystem_radio.log".format(logdir),
name="monitoring_filesystem_radio",
level=logging.INFO)
Expand Down

0 comments on commit 166cb03

Please sign in to comment.