Skip to content

Commit

Permalink
Remove unused channel directory handling code (#3689)
Browse files Browse the repository at this point in the history
This is part of implementing #3515 channel removal code. These methods
became unused in PR #3688.

## Type of change

- Code maintenance/cleanup
  • Loading branch information
benclifford authored Nov 8, 2024
1 parent e27f162 commit 3fa1599
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 56 deletions.
28 changes: 0 additions & 28 deletions parsl/channels/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,31 +80,3 @@ def pull_file(self, remote_source: str, local_dir: str) -> str:
destination_path (string)
'''
pass

@abstractmethod
def makedirs(self, path: str, mode: int = 0o511, exist_ok: bool = False) -> None:
"""Create a directory.
If intermediate directories do not exist, they will be created.
Parameters
----------
path : str
Path of directory to create.
mode : int
Permissions (posix-style) for the newly-created directory.
exist_ok : bool
If False, raise an OSError if the target directory already exists.
"""
pass

@abstractmethod
def isdir(self, path: str) -> bool:
"""Return true if the path refers to an existing directory.
Parameters
----------
path : str
Path of directory to check.
"""
pass
28 changes: 0 additions & 28 deletions parsl/channels/local/local.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,34 +91,6 @@ def push_file(self, source, dest_dir):
def pull_file(self, remote_source, local_dir):
return self.push_file(remote_source, local_dir)

def isdir(self, path):
"""Return true if the path refers to an existing directory.
Parameters
----------
path : str
Path of directory to check.
"""

return os.path.isdir(path)

def makedirs(self, path, mode=0o700, exist_ok=False):
"""Create a directory.
If intermediate directories do not exist, they will be created.
Parameters
----------
path : str
Path of directory to create.
mode : int
Permissions (posix-style) for the newly-created directory.
exist_ok : bool
If False, raise an OSError if the target directory already exists.
"""

return os.makedirs(path, mode, exist_ok)

@property
def script_dir(self):
return self._script_dir
Expand Down

0 comments on commit 3fa1599

Please sign in to comment.