Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct whitespace in InvalidResourceSpecification message #3633

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Correct whitespace in InvalidResourceSpecification message #3633

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c297f
Correct whitespace in InvalidResourceSpecification message
benclifford Oct 13, 2024
7eed9c4
Merge branch 'master' into benc-whitespace-mpi
benclifford Oct 14, 2024
432a3c9
Merge branch 'master' into benc-whitespace-mpi
benclifford Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parsl/executors/high_throughput/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,9 @@ def validate_resource_spec(self, resource_specification: dict):
if resource_specification:
raise InvalidResourceSpecification(
set(resource_specification.keys()),
("HTEX does not support the supplied resource_specifications."
("HTEX does not support the supplied resource_specifications. "
"For MPI applications consider using the MPIExecutor. "
"For specifications for core count/memory/walltime, consider using WorkQueueExecutor. ")
"For specifications for core count/memory/walltime, consider using WorkQueueExecutor.")
Comment on lines -349 to +351
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I have found that putting the space(s) to join lines at the beginning of the following line easier to see and not leave this kind of detritus. Obviously not for this PR, but as a habit/mental trick to myself. 🤷

)
return

Expand Down
Loading